Merged
Conversation
Contributor
iMax-pp
commented
Jul 12, 2015
iMax-pp
commented
- Fix build
- Update README
- Add Travis CI support (e.g. https://travis-ci.org/iMax-pp/intools-engine)
intools.types.go
Outdated
Owner
There was a problem hiding this comment.
Why did you change the interface by the type ? Keeping the interface dockerclient.Client will be more reliable to mock Docker for unit tests
Contributor
Author
There was a problem hiding this comment.
It might be a problem with the dockerclient dependency, but on my machine I have the following error, when using dockerclient.Client:
dockerclient.DockerClient does not implement dockerclient.Client (ContainerChanges method has pointer receiver)
Contributor
Author
|
Issue opened on dockerclient repo: samalba/dockerclient#134 |
fsamin
added a commit
that referenced
this pull request
Jul 13, 2015
Fix Build. Add Travis CI support
Contributor
Author
|
Once the issue is fixed on |
Owner
|
yep, issue #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.